Loading Animation by ukaylee · Pull Request #178 · cuappdev/uplift-ios-swiftui

ukaylee · 2026-09-10T02:51:43Z

Overview

Implemented loading animation according to design

Collaborated with Anatoli: I worked on adding the background image, animating the Uplift logo, and linking the intro animation to SignInView with a transition

Added state inside of SignInView to behave differently on the user's first open of the app to show the loading animation + animate the logo differently. It should not appear in any other use of SignInView (like on the profile)

Video

Screen.Recording.2026-09-09.at.10.43.36.PM.mov

Bring the loading animation branch up to date with main (24 commits behind). Resolved conflicts: - User.swift, MainViewModel.swift: kept main's versions. The WIP workarounds (hardcoded goal value, commented-out User init) were only needed because the branch's .graphql files were stale. - mountain_back / mountain_front Contents.json: kept main's filenames. - project.pbxproj: kept both sides so IntroAnimationView.swift stays in the target alongside main's new files. This also fixes the "Missing package product" build errors: the old UserMutations.graphql declared workoutGoal as [String]! while the backend expects Int!, so Apollo codegen failed and UpliftAPI/Package.swift was never generated.

…into anatoli/loading-animation

coderabbitai · 2026-09-10T02:51:50Z

Important

🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 4f236c9d-c973-4115-a648-27f6b6d2cd53

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

JiwonJeong414

Nice work Kaylee! Just a couple of comments to consider 👍

JiwonJeong414 · 2026-09-11T02:36:14Z

+{
+  "images" : [
+    {
+      "filename" : "intro_background.png",


do we not have 2x 3x files for this? you need the 2x 3x file so that the photo does not get blurry. also do we use png for our assets or svgs can you check the other files?

it looks like pngs inside of Assets.xcassets

JiwonJeong414 · 2026-09-11T02:37:25Z

-                .offset(y: animateElements ? 0 : 200)
-                .animation(.smooth(duration: 2), value: animateElements)
+
+            Color.clear // to give enough space for logo!


JiwonJeong414 · 2026-09-11T02:40:49Z

    @StateObject private var loginViewModel = LoginViewModel()
    @State private var animateElements: Bool = false
+    @State private var showIntro = !SignInView.hasShownIntro
+


hmmm, this looks like state logic don't you think we can do something like
enum Phase {
case hidden
case entered
case transitioningToSignIn
case finished
}

You could either make this @observable or define it through your 2nd view model

JiwonJeong414 · 2026-09-11T02:41:19Z

+
+    // MARK: - Helpers
+
+    // logo properties


there's a lot of magic numbers (constants) that should be put into the constants file

JiwonJeong414 · 2026-09-11T02:43:13Z

+    // MARK: - Helpers
+
+    // logo properties
+    private var mainLogoSize: CGSize {


I actually think here is a good structure to try utilizing two view models try adding this @State private var animationViewModel = SignInAnimationViewModel() at the top and adding all these private vars and private func, good separation of concerns

JiwonJeong414 · 2026-09-11T02:44:51Z

+
+    // MARK: - Views
+
+        private var backgroundImage: some View {


weird tab delete the tab starting from line 59

JiwonJeong414 · 2026-09-11T02:45:14Z

+                )
+        }
+
+    // MARK: - Helpers


same here I feel like you could have a 2nd viewmodel for the animations try it and see if you like the 2nd viewmodel architecture

JiwonJeong414 · 2026-09-11T02:45:27Z

+        guard height > 0 else { return }
+
+        DispatchQueue.main.async {
+            hasEntered = true


same here let's not use Dispatchqueue

JiwonJeong414 · 2026-09-11T02:45:35Z

+
+                onTransition?()
+
+                DispatchQueue.main.asyncAfter(deadline: .now() + 0.35) {


here as well

JiwonJeong414 · 2026-09-11T02:45:39Z

+            hasEntered = true
+
+            DispatchQueue.main.asyncAfter(deadline: .now() + 1.5) {
+                withAnimation(.smooth(duration: 0.35)) {


here as well

…w + SignInView

JiwonJeong414

Nice Kaylee! I made a few more comments but I'm trusting you to fix them before merging. BTW you can track which comments you addressed by resolving them, it's easier for me to see as well the progress you are making.

JiwonJeong414 · 2026-09-12T00:20:35Z

This file is the same size as one above this looks sus 3x should have a file size bigger than the 2x

JiwonJeong414 · 2026-09-12T00:21:04Z

same here these are all the same size. in the figma there should be a way to export 2x, 3x of an asset

JiwonJeong414 · 2026-09-12T00:21:14Z

+    /// Constants used in IntroAnimation
+    enum IntroAnimation {
+        static let entranceDuration: Double = 1.0
+        static let entranceDelay: Double = 0.1


amonsalve1 and others added 12 commits March 22, 2026 20:33

animation wip

030a06d

Merge branch 'main' of https://github.com/cuappdev/uplift-ios-swiftui …

b7d9f21

…into anatoli/loading-animation

chore: added gradient background + appdev logo with fade in animatiom

625534b

chore: chained introanimationview to signinview

6f7722d

(chore): transitioning between intro animation to sign in

5bacdf7

chore: fixed appdev logo speed

66c8091

chore: refactoring introanimationview for readability

944f1c4

feat: yay the animation works

c3d0606

chore: cleaning up code

27c7db8

chore: reverting mountains, also making the back one go up higher

f4bfa41

chore: switched to sunset logo during intro animation

16a5a0f

ukaylee requested review from JiwonJeong414 and amonsalve1 September 10, 2026 02:51

JiwonJeong414 requested changes Sep 11, 2026

View reviewed changes

ukaylee added 9 commits September 10, 2026 23:50

chore(revisions): addressed stray code

b0c2c9f

chore(revisions): some constants

2feb851

chore(revisions): replacing DispatchQueue with async + tasks

98f1480

chore(revisions): refactor by making ViewModels for IntroAnimationVie…

79aaf0a

…w + SignInView

chore(revisions): converting variables into enum

b2b2f8c

chore(revisions): fixing line length violations

9cb223c

chore(revisions): making many constants

46577d4

chore(revisions): moving constants to constants file

b7a7314

chore(revisions): updating images to have 1x 2x 3x

9f35c05

JiwonJeong414 approved these changes Sep 12, 2026

View reviewed changes


		onTransition?()

		DispatchQueue.main.asyncAfter(deadline: .now() + 0.35) {

Uh oh!

Conversation

ukaylee commented Sep 10, 2026

Overview

Video

Uh oh!

coderabbitai Bot commented Sep 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JiwonJeong414 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JiwonJeong414 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coderabbitai Bot commented Sep 10, 2026 •

edited

Loading